Move the list of coercions to the reference #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
approved these changes
Jul 6, 2021
src/coercions.md
Outdated
|
|
||
| Coercion is allowed between the following types: | ||
| ## Cases where coercions do not perform |
There was a problem hiding this comment.
Suggested change
| ## Cases where coercions do not perform | |
| ## Cases where coercions do not happen |
(but I would drop the subheading altogether -- this is already a very short page now)
src/coercions.md
Outdated
| @@ -67,20 +25,21 @@ fn main() { | |||
| } | |||
| ``` | |||
|
|
|||
| which fails like the following: | |||
There was a problem hiding this comment.
Suggested change
| which fails like the following: | |
| which fails as follows: |
src/coercions.md
Outdated
| `U`, that does not constitute an implementation for `T`. For example, the | ||
| following will not type check, even though it is OK to coerce `t` to `&T` and | ||
| there is an impl for `&T`: | ||
| Note that we do not perform coercions when matching traits (except for receivers, see below). |
There was a problem hiding this comment.
Suggested change
| Note that we do not perform coercions when matching traits (except for receivers, see below). | |
| Note that we do not perform coercions when matching traits (except for receivers, see the next page). |
This is a pre-existing error, but still should be fixed.
|
Thanks! Applied all the review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #279: