Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[allow(unsafe_code)] to projection macros #24

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Add #[allow(unsafe_code)] to projection macros #24

merged 2 commits into from
Oct 16, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 16, 2019

I feel the current behavior of lint is a little odd, but I'd like to prevent unsafe macros from being used on the crate that forbids unsafe_code.

This may break some crate, but pin-utils is still alpha, so should be acceptable.

Closes #2

r? @cramertj
cc @Nemo157

@Nemo157
Copy link
Member

Nemo157 commented Oct 16, 2019

Opened rust-lang/rustup#2065 about the CI failure, it's fallout from the last rustup release.

Since Pin is stable now it might be a good idea to move the clippy job over to using the stable channel so it will be guaranteed to exist.

@Nemo157
Copy link
Member

Nemo157 commented Oct 16, 2019

new rustup released which should fix this, so rerunning this build should work (but I'll probably still look at updating to use stable later).

@taiki-e taiki-e closed this Oct 16, 2019
@taiki-e taiki-e reopened this Oct 16, 2019
@Nemo157
Copy link
Member

Nemo157 commented Oct 16, 2019

Still broken because the cache has stored the broken state... if someone has access to clear the cache it should fix it.

@cramertj cramertj merged commit 697a723 into rust-lang:master Oct 16, 2019
@taiki-e taiki-e deleted the unsafe-code branch October 16, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe macros and #![forbid(unsafe_code)]
3 participants