Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rpath support #131

Merged
merged 7 commits into from
Mar 31, 2022
Merged

Adding rpath support #131

merged 7 commits into from
Mar 31, 2022

Conversation

eulegang
Copy link

I'm not quite sure if this project wants to support it, but it would be a nice to have in my opinion.

Copy link
Collaborator

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems like a good idea, but instead of supporting specific linker arguments it would probably make more sense to pass through all -Wl arguments as-is to the linker. In addition to -rpath there's for example also -rpath-link which is quite useful to have.

Can you update the PR?

@eulegang
Copy link
Author

Seems like a decent idea.

@eulegang
Copy link
Author

Hopefully the ld_options is a suitable name. Something tells me it's not the worst idea to add it to the library struct for build scripts. If so something tells me we should also split the options by comma and with the -Wl, trimmed.

I'll update and worst case we strip it out.

tests/test.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants