Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move intrinsic declarations to core and verify behavior #381

Closed
calebzulawski opened this issue Dec 11, 2023 · 1 comment · Fixed by rust-lang/rust#118853
Closed

Move intrinsic declarations to core and verify behavior #381

calebzulawski opened this issue Dec 11, 2023 · 1 comment · Fixed by rust-lang/rust#118853

Comments

@calebzulawski
Copy link
Member

calebzulawski commented Dec 11, 2023 •
edited
Loading

The intrinsics should exist in core, which will make them easier to test and document. There is currently no single set of documentation explaining the semantics of the intrinsics, so this module would serve as the "definitive" description.

Additionally, we should ensure that the semantics match the documentation and is sound.
@calebzulawski calebzulawski mentioned this issue Dec 11, 2023
Open
@calebzulawski calebzulawski changed the title Move intrinsic declarations to core Move intrinsic declarations to core and verify behavior Dec 11, 2023
@RalfJung
Copy link
Member

RalfJung commented Dec 11, 2023 •
edited
Loading

Additionally, we should ensure that the semantics match the documentation and is sound.

Note that there are two semantics:

  • the codegen backend(s), which "just" has to generate correct behavior whenever the safety requirements are met
  • Miri, which also has to check whether the safety requirements are actually met

@calebzulawski calebzulawski mentioned this issue Dec 12, 2023
Merged
RalfJung pushed a commit to RalfJung/miri that referenced this issue Dec 21, 2023
@bors
Auto merge of #118853 - calebzulawski:simd-intrinsics, r=RalfJung
e3a582b 
Add core::intrinsics::simd

Intended to close rust-lang/portable-simd#381.

r? ralfjung
@calebzulawski calebzulawski mentioned this issue Dec 29, 2023
Merged
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
@bors
Auto merge of #118853 - calebzulawski:simd-intrinsics, r=RalfJung
84bec95 
Add core::intrinsics::simd

Intended to close rust-lang/portable-simd#381.

r? ralfjung
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #118853 - calebzulawski:simd-intrinsics, r=RalfJung
4ee2276 
Add core::intrinsics::simd

Intended to close rust-lang/portable-simd#381.

r? ralfjung
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add core::intrinsics::simd calebzulawski/rust
2 participants
@RalfJung @calebzulawski