Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo features #155

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Fix cargo features #155

merged 4 commits into from
Sep 9, 2021

Conversation

calebzulawski
Copy link
Member

@calebzulawski calebzulawski commented Aug 8, 2021 •
edited
Loading

I realized with my previous PR I forgot to actually disable the nightly features... Fixes #156

@calebzulawski
Copy link
Member Author

Updated to fix #156 as well

@calebzulawski
Copy link
Member Author

Looks like something is broken with the x86-64 backend on current nightly?

@workingjubilee
Copy link
Member

Kicked over server to rerun the tests, local tests pass as of tonight 2021-09-04.

@workingjubilee
Copy link
Member

workingjubilee commented Sep 5, 2021 •
edited
Loading

Doesn't particularly make sense why it would fail on all x86_64 SIMD versions without exception but pass on i686 without exception.

Always failing on the byte ops, too, while passing on anything wider, and with subtly different issues (SIGTRAP, SIGILL, etc.) each time. Turns out though that if I remember to turn on --release that I successfully break it locally. Huzzah!

@workingjubilee
Copy link
Member

I am 99% certain this is due to the recent LLVM 13 upgrade. Due to the recent const generics changes on nightly, it is easier to continue work on this repo if we merge this PR and wait for the LLVM version to be fixed, as this likely is fine with LLVM 12.

@workingjubilee workingjubilee merged commit 8cf7a62 into master Sep 9, 2021
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2021
Closed
@workingjubilee workingjubilee deleted the bugfix/const_eval_checked branch January 26, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee Awaiting requested review from workingjubilee

@programmerjake programmerjake Awaiting requested review from programmerjake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't compile with latest nightly
2 participants
@calebzulawski @workingjubilee