Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed need for generic_const_expr in bitmask #237

Closed
wants to merge 2 commits into from
Closed

Removed need for generic_const_expr in bitmask #237

wants to merge 2 commits into from

Conversation

jorgecarleitao
Copy link
Contributor

Closes #223

@jorgecarleitao
Copy link
Contributor Author

I am not sure if this is sufficient - I can't find the tests where we cover compiling under certain feature sets.

@workingjubilee
Copy link
Member

workingjubilee commented Feb 5, 2022

Most of it is a simple feature-test on GitHub Actions.

You would need to remove the cfg from inside the tests.

You should also remove the feature entirely from the crate, as it is used nowhere else.

@jorgecarleitao
Copy link
Contributor Author

I think that the feature is still in use in another part of the crate (module to_bytes).

@workingjubilee
Copy link
Member

Ah, you are right actually. I forgot about that.
Also for some reason altering the ci.yaml stopped the tests from running entirely...

@jorgecarleitao
Copy link
Contributor Author

Sorry, that was a bad commit. Fixed it.

@workingjubilee
Copy link
Member

???
...I have no idea what's wrong here.

@jorgecarleitao
Copy link
Contributor Author

Closing in favor of #238, since there is something going on with the CI in this one

@jorgecarleitao jorgecarleitao deleted the genericless branch February 5, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make from/to_bitmask not depend on generic_const_exprs
2 participants