Add scalar shifts #360
Merged
Add scalar shifts #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmerjake
approved these changes
Jul 28, 2023
|
maybe add a smoke test? |
programmerjake
approved these changes
Jul 29, 2023
thomcc
approved these changes
Jul 29, 2023
|
I still want all of them tbh! I agree these are less likely to break stuff due to bad type inference though, since shifts are already weird about the shamt operand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think shifts are different than
Add,Mul, etc, and warrant these auto-splatting trait impls. Unlike arithmetic, it's not clear to users that the correct LLVM IR is a splatted shift, and they expect something that looks more like a unary op. Closes #225.