Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Provide diagnostic suggestion in ExprUseVisitor Delegate #20

Closed
arora-aman opened this issue Oct 20, 2020 · 1 comment · Fixed by rust-lang/rust#78662
Closed

Provide diagnostic suggestion in ExprUseVisitor Delegate #20

arora-aman opened this issue Oct 20, 2020 · 1 comment · Fixed by rust-lang/rust#78662
Assignees
@null-sleep
Milestone
Feature complete

Comments

@arora-aman
Copy link
Member

arora-aman commented Oct 20, 2020 •
edited
Loading

The Delegate trait currently use PlaceWithHirId which is composed of Hir Place and the corresponding expression id.

Even though this is an accurate way of expressing how a Place is used, it can cause confusion during diagnostics.

Eg:

let arr : [String; 5];

let [a, ...]     =   arr;
 ^^^ E1 ^^^      =  ^^E2^^

Here arr is moved because of the binding created E1. However, when we point to E1 in diagnostics with the message arr was moved, it can be confusing. Rather we would like to report E2 to the user.

We want to modify the Delegate methods to provide an expression that should be used for diagnostics.

We have tried to previously achieve something similar before https://github.com/rust-lang/rust/pull/75933/files#diff-1f18144176a6e44f905262991bed987098348cdbd688ac76f8c915ec91b7fd58R316-R319
@arora-aman
Copy link
Member Author

ExprUseVisitor is currently used in typeck/check/upvar.rs and src/tools/clippy

This was referenced Oct 22, 2020
Closed
Merged
@arora-aman arora-aman mentioned this issue Oct 23, 2020
Merged
@arora-aman arora-aman changed the title Decouple Place and Expression in ExprUseVisitor Delegate Provide diagnostic suggestion in ExprUseVisitor Delegate Nov 2, 2020
null-sleep added a commit to sexxi-goose/rust that referenced this issue Nov 2, 2020
@null-sleep
Provide diagnostic suggestion in ExprUseVisitor Delegate
30b462e 
The [Delegate
trait](https://github.com/rust-lang/rust/blob/981346fc07dd5ef414c5b1b21999f7604cece006/compiler/rustc_typeck/src/expr_use_visitor.rs#L28-L38)
currently use `PlaceWithHirId` which is composed of Hir `Place` and the
corresponding expression id.

Even though this is an accurate way of expressing how a Place is used,
it can cause confusion during diagnostics.

Eg:

```
let arr : [String; 5];

let [a, ...]     =   arr;
 ^^^ E1 ^^^      =  ^^E2^^
 ```

 Here `arr` is moved because of the binding created E1. However, when we
 point to E1 in diagnostics with the message `arr` was moved, it can be
 confusing.  Rather we would like to report E2 to the user.

 Closes: rust-lang/project-rfc-2229#20
@null-sleep null-sleep mentioned this issue Nov 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 4, 2020
@bors
Auto merge of rust-lang#78662 - sexxi-goose:add_expr_id_to_delegate, …
0fb0025 
…r=nikomatsakis

Provide diagnostic suggestion in ExprUseVisitor Delegate

The [Delegate trait](https://github.com/rust-lang/rust/blob/981346fc07dd5ef414c5b1b21999f7604cece006/compiler/rustc_typeck/src/expr_use_visitor.rs#L28-L38) currently use `PlaceWithHirId` which is composed of Hir `Place` and the
corresponding expression id.

Even though this is an accurate way of expressing how a Place is used,
it can cause confusion during diagnostics.

Eg:

```
let arr : [String; 5];

let [a, ...]     =   arr;
 ^^^ E1 ^^^      =  ^^E2^^
 ```

 Here `arr` is moved because of the binding created E1. However, when we
 point to E1 in diagnostics with the message `arr` was moved, it can be
 confusing.  Rather we would like to report E2 to the user.

 Closes: rust-lang/project-rfc-2229#20

r? `@ghost`
giraffate pushed a commit to giraffate/rust-clippy that referenced this issue Nov 5, 2020
@null-sleep
Provide diagnostic suggestion in ExprUseVisitor Delegate
5f97326 
The [Delegate
trait](https://github.com/rust-lang/rust/blob/981346fc07dd5ef414c5b1b21999f7604cece006/compiler/rustc_typeck/src/expr_use_visitor.rs#L28-L38)
currently use `PlaceWithHirId` which is composed of Hir `Place` and the
corresponding expression id.

Even though this is an accurate way of expressing how a Place is used,
it can cause confusion during diagnostics.

Eg:

```
let arr : [String; 5];

let [a, ...]     =   arr;
 ^^^ E1 ^^^      =  ^^E2^^
 ```

 Here `arr` is moved because of the binding created E1. However, when we
 point to E1 in diagnostics with the message `arr` was moved, it can be
 confusing.  Rather we would like to report E2 to the user.

 Closes: rust-lang/project-rfc-2229#20
giraffate pushed a commit to giraffate/rust-clippy that referenced this issue Nov 5, 2020
@bors
Auto merge of #78662 - sexxi-goose:add_expr_id_to_delegate, r=nikomat…
0c1531a 
…sakis

Provide diagnostic suggestion in ExprUseVisitor Delegate

The [Delegate trait](https://github.com/rust-lang/rust/blob/981346fc07dd5ef414c5b1b21999f7604cece006/compiler/rustc_typeck/src/expr_use_visitor.rs#L28-L38) currently use `PlaceWithHirId` which is composed of Hir `Place` and the
corresponding expression id.

Even though this is an accurate way of expressing how a Place is used,
it can cause confusion during diagnostics.

Eg:

```
let arr : [String; 5];

let [a, ...]     =   arr;
 ^^^ E1 ^^^      =  ^^E2^^
 ```

 Here `arr` is moved because of the binding created E1. However, when we
 point to E1 in diagnostics with the message `arr` was moved, it can be
 confusing.  Rather we would like to report E2 to the user.

 Closes: rust-lang/project-rfc-2229#20

r? `@ghost`
Ryan1729 pushed a commit to Ryan1729/rust-clippy that referenced this issue Nov 7, 2020
@null-sleep @Ryan1729
Provide diagnostic suggestion in ExprUseVisitor Delegate
0b7976b 
The [Delegate
trait](https://github.com/rust-lang/rust/blob/981346fc07dd5ef414c5b1b21999f7604cece006/compiler/rustc_typeck/src/expr_use_visitor.rs#L28-L38)
currently use `PlaceWithHirId` which is composed of Hir `Place` and the
corresponding expression id.

Even though this is an accurate way of expressing how a Place is used,
it can cause confusion during diagnostics.

Eg:

```
let arr : [String; 5];

let [a, ...]     =   arr;
 ^^^ E1 ^^^      =  ^^E2^^
 ```

 Here `arr` is moved because of the binding created E1. However, when we
 point to E1 in diagnostics with the message `arr` was moved, it can be
 confusing.  Rather we would like to report E2 to the user.

 Closes: rust-lang/project-rfc-2229#20
@nikomatsakis nikomatsakis added this to the Feature complete milestone Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@null-sleep null-sleep

Labels
None yet
Projects
None yet
Milestone
Feature complete
Development

Successfully merging a pull request may close this issue.

Provide diagnostic suggestion in ExprUseVisitor Delegate sexxi-goose/rust
3 participants
@nikomatsakis @arora-aman @null-sleep