Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Account for capture kind in trait migration #51

Closed
arora-aman opened this issue Jun 30, 2021 · 1 comment · Fixed by rust-lang/rust#86869
Closed

Account for capture kind in trait migration #51

arora-aman opened this issue Jun 30, 2021 · 1 comment · Fixed by rust-lang/rust#86869
Assignees
@roxelo
Labels
bug Something isn't working

Comments

@arora-aman
Copy link
Member

Currently the code that does checks for trait bounds that won't be met in 2021 doesn't include the capture kind in the type of the captured path.

For computing the capture kind as per 2018:

  • If move closure, then capture kind = ByValue
  • else, Max capture kind according to Imm < UniqueImm < Mut < ByValue
@arora-aman arora-aman added the bug Something isn't working label Jun 30, 2021
@roxelo roxelo mentioned this issue Jul 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 9, 2021
@bors
Auto merge of rust-lang#86869 - sexxi-goose:rfc2229-migration-capture…
b090cd1 
…-kind, r=nikomatsakis

Account for capture kind in auto traits migration

Modifies the current auto traits migration for RFC2229 so it takes into account capture kind

Closes rust-lang/project-rfc-2229#51

r? `@nikomatsakis`
@nikomatsakis
Copy link
Contributor

This was fixed by rust-lang/rust#86869

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roxelo roxelo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account for capture kind in auto traits migration sexxi-goose/rust
3 participants
@nikomatsakis @arora-aman @roxelo