Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to InstanceDef and monomorphized Instance #36

Closed
celinval opened this issue Sep 18, 2023 · 2 comments
Closed

Add support to InstanceDef and monomorphized Instance #36

celinval opened this issue Sep 18, 2023 · 2 comments
Assignees

Comments

@celinval
Copy link
Contributor

We should be able to create a stable version of Instance since we now have GenericArgs. This will help us work with monomorphized code.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 19, 2023

Where do we get it from? Or do you mean for creating manually and then getting the MIR for it?

@celinval
Copy link
Contributor Author

celinval commented Sep 21, 2023

Where do we get it from? Or do you mean for creating manually and then getting the MIR for it?

Yes. In Kani we usually start traversing from non-generic functions and momomorphize as needed.

I also think it's ok if for now we expose a conversion from internal to stable.

@celinval celinval self-assigned this Oct 14, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 17, 2023
Add MonoItems and Instance to stable_mir

Also add a few methods to instantiate instances and get an instance definition. We're still missing support to actually monomorphize the instance body.

This is related to rust-lang/project-stable-mir#36

r? `@oli-obk`

`@oli-obk` is that what you were thinking? I incorporated `@bjorn3` idea of just adding a Shim instance definition in rust-lang#116465.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 17, 2023
Add MonoItems and Instance to stable_mir

Also add a few methods to instantiate instances and get an instance definition. We're still missing support to actually monomorphize the instance body.

This is related to rust-lang/project-stable-mir#36

r? ``@oli-obk``

``@oli-obk`` is that what you were thinking? I incorporated ``@bjorn3`` idea of just adding a Shim instance definition in rust-lang#116465.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 17, 2023
Rollup merge of rust-lang#116719 - celinval:smir-mono, r=oli-obk

Add MonoItems and Instance to stable_mir

Also add a few methods to instantiate instances and get an instance definition. We're still missing support to actually monomorphize the instance body.

This is related to rust-lang/project-stable-mir#36

r? ``@oli-obk``

``@oli-obk`` is that what you were thinking? I incorporated ``@bjorn3`` idea of just adding a Shim instance definition in rust-lang#116465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants