Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to find implemented trait in the list returned from all_trait_decls #37

Closed
celinval opened this issue Sep 26, 2023 · 1 comment · Fixed by rust-lang/rust#119790
Closed

Fail to find implemented trait in the list returned from all_trait_decls #37

celinval opened this issue Sep 26, 2023 · 1 comment · Fixed by rust-lang/rust#119790
Assignees
@celinval
Labels
bug Something isn't working

Comments

@celinval
Copy link
Contributor

celinval commented Sep 26, 2023 •
edited by rustbot
Loading

This could be a naming issue, but I expect all_trait_decls and all_trait_impls to return all traits declarations and implementations available, i.e.:, all local and external traits.

Maybe we can rename these functions to local_trait_decls and local_trait_impls. In this case, should we also provide an API that returns trait declarations and implementations from external crates.
@celinval celinval added the bug Something isn't working label Sep 26, 2023
@celinval
Copy link
Contributor Author

celinval commented Jan 9, 2024

@rustbot claim

@celinval celinval mentioned this issue Jan 9, 2024
Merged
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 11, 2024
@rust-timer
Unrolled build for rust-lang#119790
713d532 
Rollup merge of rust-lang#119790 - celinval:smir-all-traits, r=oli-obk

Fix all_trait* methods to return all traits available in StableMIR

Also provide a mechanism to retrieve traits and implementations for a given crate.

This fixes rust-lang/project-stable-mir#37
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jan 11, 2024
@matthiaskrgr
Rollup merge of #119790 - celinval:smir-all-traits, r=oli-obk
48b44f8 
Fix all_trait* methods to return all traits available in StableMIR

Also provide a mechanism to retrieve traits and implementations for a given crate.

This fixes rust-lang/project-stable-mir#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@celinval celinval

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix all_trait* methods to return all traits available in StableMIR celinval/rust-dev
1 participant
@celinval