Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-structure 'invalid values' enumeration to instead define what is *valid* #1540

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

RalfJung
Copy link
Member

I've always been bothered by the fact that was are listing what is invalid, which just feels all backwards. So this PR changes that list to instead enumerate what is valid. We also move that list into its own subsection to give a bit more structure to this entire page.

Copy link
Contributor

@chorman0773 chorman0773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the things listed in the review, seems to be correct and editorially sound.

src/behavior-considered-undefined.md Outdated Show resolved Hide resolved
src/behavior-considered-undefined.md Outdated Show resolved Hide resolved
src/behavior-considered-undefined.md Outdated Show resolved Hide resolved
src/behavior-considered-undefined.md Outdated Show resolved Hide resolved
@traviscross traviscross enabled auto-merge July 23, 2024 22:56
@traviscross traviscross added this pull request to the merge queue Jul 23, 2024
Merged via the queue into rust-lang:master with commit c34aa00 Jul 23, 2024
1 check passed
@RalfJung RalfJung deleted the valid branch August 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants