Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update function-pointer.md for stabilization of extended_varargs_abi_support" #1734

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

chorman0773
Copy link
Contributor

@chorman0773 chorman0773 commented Feb 12, 2025

Reverts #1687

In Re. rust-lang/rust#116161 (comment) and rust-lang/rust#136896

Waiting on action on rust#136896, so I've marked this as S-waiting-on-team.

Tracking:

@chorman0773 chorman0773 added T-spec Team: spec S-waiting-on-team Status: This is waiting for action from some team. labels Feb 12, 2025
@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Feb 12, 2025
@traviscross traviscross added this pull request to the merge queue Feb 12, 2025
Merged via the queue into master with commit 6195dbd Feb 12, 2025
5 checks passed
@cuviper
Copy link
Member

cuviper commented Feb 12, 2025

I suppose this needs a submodule update in rust beta as well -- is there a branch for that, or should we just take master?

@ehuss
Copy link
Contributor

ehuss commented Feb 12, 2025

We would need to set up a branch here. How important is that?

@cuviper
Copy link
Member

cuviper commented Feb 12, 2025

How important is that?

That's more a question for you and the rest of lang-docs -- will you be bothered if the 1.85 reference states varargs support that doesn't actually work?

jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 13, 2025
Update books

## rust-lang/book

1 commits in e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45..d4d2c18cbd20876b2130a546e790446a8444cb32
2025-02-12 16:22:54 UTC to 2025-02-12 16:22:54 UTC

- Fix example for `cargo fix` (rust-lang/book#4226)

## rust-lang/reference

3 commits in de2d5289e45506b11dd652bef4f99de64be70e1c..6195dbd70fc6f0980c314b4d23875ac570d8253a
2025-02-12 15:40:30 UTC to 2025-02-11 20:35:17 UTC

- Revert "Update function-pointer.md for stabilization of `extended_varargs_abi_support`" (rust-lang/reference#1734)
- Rework error handling in mdbook-spec (rust-lang/reference#1733)
- `as` cast improvements (rust-lang/reference#1732)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 13, 2025
Update books

## rust-lang/book

1 commits in e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45..d4d2c18cbd20876b2130a546e790446a8444cb32
2025-02-12 16:22:54 UTC to 2025-02-12 16:22:54 UTC

- Fix example for `cargo fix` (rust-lang/book#4226)

## rust-lang/reference

3 commits in de2d5289e45506b11dd652bef4f99de64be70e1c..6195dbd70fc6f0980c314b4d23875ac570d8253a
2025-02-12 15:40:30 UTC to 2025-02-11 20:35:17 UTC

- Revert "Update function-pointer.md for stabilization of `extended_varargs_abi_support`" (rust-lang/reference#1734)
- Rework error handling in mdbook-spec (rust-lang/reference#1733)
- `as` cast improvements (rust-lang/reference#1732)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2025
Rollup merge of rust-lang#136937 - rustbot:docs-update, r=ehuss

Update books

## rust-lang/book

1 commits in e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45..d4d2c18cbd20876b2130a546e790446a8444cb32
2025-02-12 16:22:54 UTC to 2025-02-12 16:22:54 UTC

- Fix example for `cargo fix` (rust-lang/book#4226)

## rust-lang/reference

3 commits in de2d5289e45506b11dd652bef4f99de64be70e1c..6195dbd70fc6f0980c314b4d23875ac570d8253a
2025-02-12 15:40:30 UTC to 2025-02-11 20:35:17 UTC

- Revert "Update function-pointer.md for stabilization of `extended_varargs_abi_support`" (rust-lang/reference#1734)
- Rework error handling in mdbook-spec (rust-lang/reference#1733)
- `as` cast improvements (rust-lang/reference#1732)
traviscross added a commit that referenced this pull request Feb 14, 2025
Revert "Update function-pointer.md for stabilization of `extended_varargs_abi_support`"
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 15, 2025
Update books

## rust-lang/book

1 commits in e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45..d4d2c18cbd20876b2130a546e790446a8444cb32
2025-02-12 16:22:54 UTC to 2025-02-12 16:22:54 UTC

- Fix example for `cargo fix` (rust-lang/book#4226)

## rust-lang/reference

3 commits in de2d5289e45506b11dd652bef4f99de64be70e1c..6195dbd70fc6f0980c314b4d23875ac570d8253a
2025-02-12 15:40:30 UTC to 2025-02-11 20:35:17 UTC

- Revert "Update function-pointer.md for stabilization of `extended_varargs_abi_support`" (rust-lang/reference#1734)
- Rework error handling in mdbook-spec (rust-lang/reference#1733)
- `as` cast improvements (rust-lang/reference#1732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: The marked PR is awaiting review from a maintainer S-waiting-on-team Status: This is waiting for action from some team. T-spec Team: spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants