Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update const eval chapter to latest changes #842

Merged
merged 5 commits into from
Jul 12, 2020
Merged

Update const eval chapter to latest changes #842

merged 5 commits into from
Jul 12, 2020

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 30, 2020

No description provided.

@oli-obk oli-obk mentioned this pull request Jun 30, 2020
Merged
ehuss
ehuss reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "const context" list be updated to include "The body of a const fn"?

src/const_eval.md Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 1, 2020

Should the "const context" list be updated to include "The body of a const fn"?

hmm... good question. It isn't really, a const fn can be invoked in a const context, and its body has a bunch of rules it needs to uphold, but these differ from the current list of const context's rules in some small and some large ways.

ehuss
ehuss reviewed Jul 2, 2020
View reviewed changes
src/const_eval.md Outdated Show resolved Hide resolved
@ehuss
Copy link
Contributor

ehuss commented Jul 12, 2020

@oli-obk can you update the point on floating point types to clarify it is for floating point operations (and preferably which operations)?

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 12, 2020

Thanks for the ping! I cleaned up a bunch of things, because there were more changes to the features in the language since I last edited this PR

ehuss
ehuss reviewed Jul 12, 2020
View reviewed changes
src/const_eval.md Outdated Show resolved Hide resolved
ehuss
ehuss approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit b43bcde into rust-lang:master Jul 12, 2020
@ehuss ehuss mentioned this pull request Jul 21, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74589 - ehuss:update-books, r=ehuss
5871ff4 
Update books

## reference

5 commits in 0ea7bc494f1289234d8800bb9185021e0ad946f0..b329ce37424874ad4db94f829a55807c6e21d2cb
2020-07-02 15:33:04 -0700 to 2020-07-20 08:54:08 -0700
- this '*' is unnecessary, and reduces readability (rust-lang/reference#853)
- Tiny typo fix (rust-lang/reference#849)
- Update const eval chapter to latest changes (rust-lang/reference#842)
- Document #[track_caller]. (rust-lang/reference#742)
- Document shebang restriction. (rust-lang/reference#823)

## book

2 commits in 84a31397b34f9d405df44f2899ff17a4828dba18..a914f2c7e5cdb771fa465de142381a51c53b580e
2020-07-04 10:50:18 -0500 to 2020-07-21 09:20:05 -0500
- Change misleading wording (rust-lang/book#2399)
- Improve wording to include Windows versions (rust-lang/book#2395)

## edition-guide

3 commits in 82bec5877c77cfad530ca11095db4456d757f668..bd6e4a9f59c5c1545f572266af77f5c7a5bad6d1
2020-06-03 08:56:02 -0500 to 2020-07-12 17:37:08 -0500
- update guide for 1.36 and 1.37 (rust-lang/edition-guide#217)
- Add contents for Rust 1.35 (rust-lang/edition-guide#216)
- update edition guide for Rust 1.34 (rust-lang/edition-guide#215)
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74589 - ehuss:update-books, r=ehuss
846d539 
Update books

## reference

5 commits in 0ea7bc494f1289234d8800bb9185021e0ad946f0..b329ce37424874ad4db94f829a55807c6e21d2cb
2020-07-02 15:33:04 -0700 to 2020-07-20 08:54:08 -0700
- this '*' is unnecessary, and reduces readability (rust-lang/reference#853)
- Tiny typo fix (rust-lang/reference#849)
- Update const eval chapter to latest changes (rust-lang/reference#842)
- Document #[track_caller]. (rust-lang/reference#742)
- Document shebang restriction. (rust-lang/reference#823)

## book

2 commits in 84a31397b34f9d405df44f2899ff17a4828dba18..a914f2c7e5cdb771fa465de142381a51c53b580e
2020-07-04 10:50:18 -0500 to 2020-07-21 09:20:05 -0500
- Change misleading wording (rust-lang/book#2399)
- Improve wording to include Windows versions (rust-lang/book#2395)

## edition-guide

3 commits in 82bec5877c77cfad530ca11095db4456d757f668..bd6e4a9f59c5c1545f572266af77f5c7a5bad6d1
2020-06-03 08:56:02 -0500 to 2020-07-12 17:37:08 -0500
- update guide for 1.36 and 1.37 (rust-lang/edition-guide#217)
- Add contents for Rust 1.35 (rust-lang/edition-guide#216)
- update edition guide for Rust 1.34 (rust-lang/edition-guide#215)
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74589 - ehuss:update-books, r=ehuss
3de0de1 
Update books

## reference

5 commits in 0ea7bc494f1289234d8800bb9185021e0ad946f0..b329ce37424874ad4db94f829a55807c6e21d2cb
2020-07-02 15:33:04 -0700 to 2020-07-20 08:54:08 -0700
- this '*' is unnecessary, and reduces readability (rust-lang/reference#853)
- Tiny typo fix (rust-lang/reference#849)
- Update const eval chapter to latest changes (rust-lang/reference#842)
- Document #[track_caller]. (rust-lang/reference#742)
- Document shebang restriction. (rust-lang/reference#823)

## book

2 commits in 84a31397b34f9d405df44f2899ff17a4828dba18..a914f2c7e5cdb771fa465de142381a51c53b580e
2020-07-04 10:50:18 -0500 to 2020-07-21 09:20:05 -0500
- Change misleading wording (rust-lang/book#2399)
- Improve wording to include Windows versions (rust-lang/book#2395)

## edition-guide

3 commits in 82bec5877c77cfad530ca11095db4456d757f668..bd6e4a9f59c5c1545f572266af77f5c7a5bad6d1
2020-06-03 08:56:02 -0500 to 2020-07-12 17:37:08 -0500
- update guide for 1.36 and 1.37 (rust-lang/edition-guide#217)
- Add contents for Rust 1.35 (rust-lang/edition-guide#216)
- update edition guide for Rust 1.34 (rust-lang/edition-guide#215)
@ehuss ehuss mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-obk @ehuss