Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the enum changes in RFC 2195 #879

Merged
merged 10 commits into from
Sep 4, 2020
Merged

Document the enum changes in RFC 2195 #879

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a76095
Document the enum changes in RFC 2195
poliorcetics Aug 21, 2020
fddf097
Address review
poliorcetics Aug 22, 2020
5a46f81
Fix nits from review, move a paragraph to a better place
poliorcetics Aug 24, 2020
ddb2fe9
Add a link and reword the start of a paragraph
poliorcetics Aug 25, 2020
75708a2
Address concerns from review and add a subsection about combining pri…
poliorcetics Aug 26, 2020
4d133a0
Improve the section Combining primitive representations of enums with…
poliorcetics Aug 27, 2020
6808c5e
Fix nits
poliorcetics Aug 31, 2020
73eae8e
Fix nits 2
poliorcetics Sep 1, 2020
6e8d93a
Remove the note altogether
poliorcetics Sep 1, 2020
eb4ec25
Use 'representation' instead of 'layout' in the examples
poliorcetics Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/type-layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,12 +440,14 @@ struct MyVariantD(MyEnumDiscriminant);

> Note: `union`s with non-`Copy` fields are unstable, see [55149].

Combining the `repr(C)` and a primitive representation is only defined for enums
with fields. The primitive representation modifies the `repr(C)` by changing the
For enums with fields, it is also possible to combining `repr(C)` and a
poliorcetics marked this conversation as resolved.
Show resolved Hide resolved
primitive representation. This modifies the [`repr(C)`] by changing the
poliorcetics marked this conversation as resolved.
Show resolved Hide resolved
representation of the discriminant enum to have the representation of the chosen
primitive representation. So, if you chose the `u8` representation, then the
poliorcetics marked this conversation as resolved.
Show resolved Hide resolved
discriminant enum would have a size and alignment of 1 byte.

[`repr(C)`]: #reprc-enums-with-fields

### The alignment modifiers

The `align` and `packed` modifiers can be used to respectively raise or lower
Expand Down