Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive Clone on Error #379

Closed
remexre opened this issue Jun 1, 2017 · 1 comment
Closed

derive Clone on Error #379

remexre opened this issue Jun 1, 2017 · 1 comment
Labels
enhancement

Comments

@remexre
Copy link
Contributor

remexre commented Jun 1, 2017

Is there a reason why Error isn't Clone?
@BurntSushi
Copy link
Member

@remexre Hmm, I don't think so. Note that regex-syntax's Error already impls Clone. It seems like Clone would be just fine for the regex error too. A PR for this one is welcome. :-)

@remexre remexre mentioned this issue Jun 2, 2017
Merged
bors added a commit that referenced this issue Jun 2, 2017
@bors
Auto merge of #380 - remexre:impls-for-error, r=BurntSushi
23aa434 
Derives Clone and PartialEq on regex::Error.

Resolves #379.
@bors bors closed this as completed in #380 Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @remexre