Fix Bug in rure_captures_len
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How embarrassing! Thank you for the fox and the test. I'm on mobile so it's hard to tell, but it looks like the C code is formatted differently from other C code in the same file. Could you make the formatting consistent? (And please also squash. :-)) Thanks! |
|
Tabs vs spaces I guess. Will fix up.
…On Sun, 14 May 2017 at 12:57, Andrew Gallant ***@***.***> wrote:
How embarrassing! Thank you for the fox and the test.
I'm on mobile so it's hard to tell, but it looks like the C code is
formatted differently from other C code in the same file. Could you make
the formatting consistent? (And please also squash. :-)) Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#365 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA9TcR_Lzyu805iTAZcAKrk2uUDGHldRks5r5uwbgaJpZM4NaWUR>
.
|
It looks like at some point in the past the captures were refactored from being a vector of start and end positions into a list of location structures. The C API still had a conversion of the length which corrected for the captures being twice the length of the number of captures. This updates the length calculation in `rure.rs` to return the correct length, and adds an assertion to the test case.
|
Awesome, thank you! @bors r+ |
|
📌 Commit 4ed2fed has been approved by |
bors
added a commit
that referenced
this pull request
May 14, 2017
Fix Bug in `rure_captures_len` It looks like at some point in the past the captures were refactored from being a vector of start and end positions into a list of location structures. The C API still had a conversion of the lenght which corrected for the captures being twice the length of the number of captures. This updates the length calculation in `rure.rs` to return the correct length, and adds an assertion to the test case.
|
☀️ Test successful - status-appveyor, status-travis |
|
\o/ |
iwillspeak
added a commit
to iwillspeak/IronRure-Batteries
that referenced
this pull request
May 15, 2017
iwillspeak
added a commit
to iwillspeak/IronRure
that referenced
this pull request
May 15, 2017
Gets the lastst versions of the native packages. These builds include the fix for rust-lang/regex#365.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like at some point in the past the captures were refactored
from being a vector of start and end positions into a list of location
structures. The C API still had a conversion of the lenght which
corrected for the captures being twice the length of the number of
captures.
This updates the length calculation in
rure.rsto return thecorrect length, and adds an assertion to the test case.