Tiny PR: update a the ByteInput comment #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some ByteInput switched to being backed by actual bytes rather than a string. This commit just removes the dangling reference to the old representation.
|
Excellent, thank you! @bors r+ |
|
📌 Commit 98ef163 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 31, 2017
Tiny PR: update a the ByteInput comment At some ByteInput switched to being backed by actual bytes rather than a string. This commit just removes the dangling reference to the old representation. I just noticed this while reading through code, so I thought I would send the patch your way.
|
💔 Test failed - status-travis |
|
I tried to reproduce that test failure by switching to beta and running both |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Nov 8, 2017
Tiny PR: update a the ByteInput comment At some ByteInput switched to being backed by actual bytes rather than a string. This commit just removes the dangling reference to the old representation. I just noticed this while reading through code, so I thought I would send the patch your way.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some ByteInput switched to being backed by actual bytes
rather than a string. This commit just removes the dangling
reference to the old representation.
I just noticed this while reading through code, so I thought I would send the patch your way.