-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic atomic #1474
Closed
Closed
Generic atomic #1474
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
- Feature Name: | ||
- Start Date: 2016-01-22 | ||
- RFC PR: (leave this empty) | ||
- Rust Issue: (leave this empty) | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
Add compiler support for generic atomic operations. | ||
|
||
# Motivation | ||
[motivation]: #motivation | ||
|
||
It is sometimes necessary or useful to use atomic operations in a generic | ||
context. | ||
|
||
```rust | ||
Atomic<T> | ||
``` | ||
|
||
where `T` is any type. This is currently possible but fails to compile if `T` is | ||
too large for the native atomic operations of the target architecture. | ||
|
||
# Detailed design | ||
[design]: #detailed-design | ||
|
||
Several new language items are added which correspond to the intrinsics listed | ||
in appendix A. For example, the following language item corresponds to the | ||
`atomic_cxchg` intrinsic: | ||
|
||
```rust | ||
#[lang = "atomic_cxchg"] | ||
fn atomic_cxchg<T>(dst: *mut T, old: T, src: T) -> T { | ||
// implementation omitted | ||
} | ||
``` | ||
|
||
When a call to one of the atomic intrinsics cannot be translated to a native | ||
operation, it is translated to a call to the corresponding language item. This | ||
language item then emulates the atomic operation. For example, it might acquire | ||
a global lock, perform the corresponding non-atomic operation, and release the | ||
global lock. | ||
|
||
One intrinsic is added: | ||
|
||
```rust | ||
fn has_native_atomic_ops<T>() -> bool; | ||
``` | ||
|
||
This intrinsic returns `false` iff a call to one of the aforementioned atomic | ||
operations is translated to a library call. | ||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
|
||
None. | ||
|
||
# Alternatives | ||
[alternatives]: #alternatives | ||
|
||
None. | ||
|
||
# Unresolved questions | ||
[unresolved]: #unresolved-questions | ||
|
||
None. | ||
|
||
# Appendix A | ||
|
||
This appendix contains the full list of intrinsics for which a corresponding | ||
language item is added. The name of the language item is the name of the | ||
intrinsic, the language item is a function, and the signature of the function is | ||
the signature of the intrinsic. | ||
|
||
```rust | ||
fn atomic_cxchg<T>(dst: *mut T, old: T, src: T) -> T; | ||
fn atomic_cxchg_acq<T>(dst: *mut T, old: T, src: T) -> T; | ||
fn atomic_cxchg_rel<T>(dst: *mut T, old: T, src: T) -> T; | ||
fn atomic_cxchg_acqrel<T>(dst: *mut T, old: T, src: T) -> T; | ||
fn atomic_cxchg_relaxed<T>(dst: *mut T, old: T, src: T) -> T; | ||
|
||
fn atomic_load<T>(src: *const T) -> T; | ||
fn atomic_load_acq<T>(src: *const T) -> T; | ||
fn atomic_load_relaxed<T>(src: *const T) -> T; | ||
fn atomic_load_unordered<T>(src: *const T) -> T; | ||
|
||
fn atomic_store<T>(dst: *mut T, val: T); | ||
fn atomic_store_rel<T>(dst: *mut T, val: T); | ||
fn atomic_store_relaxed<T>(dst: *mut T, val: T); | ||
fn atomic_store_unordered<T>(dst: *mut T, val: T); | ||
|
||
fn atomic_xchg<T>(dst: *mut T, src: T) -> T; | ||
fn atomic_xchg_acq<T>(dst: *mut T, src: T) -> T; | ||
fn atomic_xchg_rel<T>(dst: *mut T, src: T) -> T; | ||
fn atomic_xchg_acqrel<T>(dst: *mut T, src: T) -> T; | ||
fn atomic_xchg_relaxed<T>(dst: *mut T, src: T) -> T; | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be reasonable to make this intrinsic
const
?