update ManuallyDrop RFC to reflect how the implementation now looks #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Aug 1, 2018
text/1860-manually-drop.md
Outdated
| @@ -96,6 +97,9 @@ impl<T> DerefMut for ManuallyDrop<T> { | |||
| // Other common impls such as `Debug for T: Debug`. | |||
eddyb
reviewed
Aug 1, 2018
text/1860-manually-drop.md
Outdated
| @@ -96,6 +97,9 @@ impl<T> DerefMut for ManuallyDrop<T> { | |||
| // Other common impls such as `Debug for T: Debug`. | |||
| ``` | |||
|
|
|||
| The lang item will be treated specially by the compiler to not emit any drop | |||
| glue for this type. | |||
|
|
|||
| Let us apply this union to a somewhat expanded example from the motivation: | |||
There was a problem hiding this comment.
Still says union - you probably want to search the whole file.
|
Fixed nits. |
Centril
added
the
T-lang
nikomatsakis
approved these changes
Aug 9, 2018
|
We don't really have a process for updating RFCs, as they're generally meant to express design and intent rather than serve as a reference. That said, it seems fine to just fix this to more correctly describe a (stable) feature the language. |
Centril
added
A-drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects rust-lang/rust#52711. I have no idea what the correct process is here.