Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try_trait_v2: A new design for the ? desugaring #3058

Merged
merged 12 commits into from
Apr 17, 2021
Merged

try_trait_v2: A new design for the ? desugaring #3058

merged 12 commits into from
Apr 17, 2021

Commits on Jan 10, 2021

  1. Try Trait v2

    @scottmcm
    scottmcm committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    6da9633 View commit details
    Browse the repository at this point in the history

  2. Apply some fixes and feedback from zulip

    @scottmcm
    scottmcm committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    50244ad View commit details
    Browse the repository at this point in the history

  3. Add two missing returns in the desugarings 

    Thanks Nokel81 for spotting this.
    @scottmcm
    scottmcm committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    b1e4066 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Cross-link the other features mentioned in the summary

    @scottmcm
    scottmcm committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    05a1c41 View commit details
    Browse the repository at this point in the history

  2. Fix more oopses 

    Thanks mbartlett21 & ehuss & tmccombs!
    @scottmcm
    scottmcm committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    aa62c5b View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Add some new sections and examples to the Guide-level explanation

    @scottmcm
    scottmcm committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    09d5e5b View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Massive revision: Rewrite the guide-level part, flip the traits, and … 

    …move BreakHolder to future possibilities
    @scottmcm
    scottmcm committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    753b15f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Rename FromTryResidual -> FromResidual

    @scottmcm
    scottmcm committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    147bdd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Add three new sections to rationale and alternatives 

    - Why does `FromResidual` take a generic type?
- Naming the `?`-related traits and associated types
- Splitting up `Try` more

The latter two are added to the Unresolved Questions section, as requested by T-libs.
    @scottmcm
    scottmcm committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    1fdfaaf View commit details
    Browse the repository at this point in the history

  2. A few more updates from feedback

    @scottmcm
    scottmcm committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    589d2e8 View commit details
    Browse the repository at this point in the history

  3. Move the accidental interconversion support to an alternative, given … 

    …crater results.
    @scottmcm
    scottmcm committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    71aef40 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2021

  1. Move to final location; set tracking issue number.

    @scottmcm
    scottmcm committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    ab42507 View commit details
    Browse the repository at this point in the history