Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niches #3334

Closed
wants to merge 49 commits into from
Closed

Niches #3334

wants to merge 49 commits into from

Commits on Oct 23, 2022

  1. Niches

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    e62830c View commit details
    Browse the repository at this point in the history

  2. Niche is RFC 3334

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    2947255 View commit details
    Browse the repository at this point in the history

  3. Forbid structs with generic parameters affecting the non-ZST field

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    26b01d6 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    f1b671a View commit details
    Browse the repository at this point in the history

  5. Further clarify the non-guarantees about multiple niche values

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    74fee72 View commit details
    Browse the repository at this point in the history

  6. Further clarify non-support for negative values at this time

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    ae13802 View commit details
    Browse the repository at this point in the history

  7. Specify two's-complement specifically

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    ae3671a View commit details
    Browse the repository at this point in the history

  8. Discuss mapping to unsigned integer representation

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    f4b0631 View commit details
    Browse the repository at this point in the history

  9. Alternatives: Add pattern-based syntax

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    132d1f8 View commit details
    Browse the repository at this point in the history

  10. Reorder some of the reference-level explanation to group similar things

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    7a1b2e4 View commit details
    Browse the repository at this point in the history

  11. Further clarify round-trip via bytes

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    422dcd9 View commit details
    Browse the repository at this point in the history

  12. Add note about non_exhaustive.

    @joshtriplett
    joshtriplett committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    825d29c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Drop support for having ZST fields 

    Avoid unneded complications.
    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    1a36e03 View commit details
    Browse the repository at this point in the history

  2. Add future possibility of structs with ZST fields

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    ffd1965 View commit details
    Browse the repository at this point in the history

  3. Guarantee that adding a niche doesn't change storage size 

    Expand the discussion of move types under future possibilities to cover
this as something move types would enable.
    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9816724 View commit details
    Browse the repository at this point in the history

  4. Only allow simple field types

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    ca5970e View commit details
    Browse the repository at this point in the history

  5. Future possibilities: fields of reference type

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    eaf6327 View commit details
    Browse the repository at this point in the history

  6. Future possibilities: mention interaction with read-only fields

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bb5b5b9 View commit details
    Browse the repository at this point in the history

  7. Consistently use "struct" rather than "structure"

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    93d4707 View commit details
    Browse the repository at this point in the history

  8. Future possibilities: change derive(TryInto) to derive(TryFrom)

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4559ee9 View commit details
    Browse the repository at this point in the history

  9. Add language to reference section about unsafe vs safe operations

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5b03ea2 View commit details
    Browse the repository at this point in the history

  10. Add information to the guide-level section on typical operations

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    b8bcfda View commit details
    Browse the repository at this point in the history

  11. Consistently use "niche" rather than "invalid" except when explaining… 

    … "niche"
    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    c3c6154 View commit details
    Browse the repository at this point in the history

  12. Future possibilities: safe writes of compile-time constants

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bb1a8ec View commit details
    Browse the repository at this point in the history

  13. Clarify language regarding compile-time constants and verification

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    ad9bf34 View commit details
    Browse the repository at this point in the history

  14. Explicitly allow niche to appear inside cfg_attr

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    f16a730 View commit details
    Browse the repository at this point in the history

  15. Alternatives: Add detailed discussion of niche-on-field vs niche-on-s… 

    …truct
    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    ee9359f View commit details
    Browse the repository at this point in the history

  16. Explicitly allow inclusive and exclusive ranges

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    08bb5b4 View commit details
    Browse the repository at this point in the history

  17. Note that the compiler may be able to perform additional optimizations

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    77069e6 View commit details
    Browse the repository at this point in the history

  18. Discuss pattern matching

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    58d3b9e View commit details
    Browse the repository at this point in the history

  19. Explicitly allow open-ended ranges.

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    d5966c6 View commit details
    Browse the repository at this point in the history

  20. Future possibilities: add niches affecting pattern-matching exhaustiv… 

    …eness
    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    c18bee3 View commit details
    Browse the repository at this point in the history

  21. Explicitly allow construction or writing from const code

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    627df7f View commit details
    Browse the repository at this point in the history

  22. Note that #[niche(...)] would be forward-compatible with a pattern … 

    …syntax
    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5109f44 View commit details
    Browse the repository at this point in the history

  23. Discuss interaction with derive(Default)

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    f77eb45 View commit details
    Browse the repository at this point in the history

  24. Note that a derive(TryFrom) would also avoid duplicating the range

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5965de8 View commit details
    Browse the repository at this point in the history

  25. Mention C and C++ bitfields

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    811024a View commit details
    Browse the repository at this point in the history

  26. Note why we don't support bool

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    014d504 View commit details
    Browse the repository at this point in the history

  27. Add Ada as precedent

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4856096 View commit details
    Browse the repository at this point in the history

  28. Discuss how we can handle derive(Default)

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bb38342 View commit details
    Browse the repository at this point in the history

  29. Explicitly conflict with repr(packed)

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    c20796c View commit details
    Browse the repository at this point in the history

  30. Alternative regarding derive(Default)

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    7f27700 View commit details
    Browse the repository at this point in the history

  31. Discuss mutable references in more detail

    @joshtriplett
    joshtriplett committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    b8e0397 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. s/primitive integer type/built-in integer type/

    @joshtriplett
    joshtriplett committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    48d1c22 View commit details
    Browse the repository at this point in the history

  2. s/either zero or one/at most one/

    @joshtriplett
    joshtriplett committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    6cf4c4e View commit details
    Browse the repository at this point in the history

  3. Clarify what else adding a niche *doesn't* change (alignment, other A… 

    …BI details)
    @joshtriplett
    joshtriplett committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    a011965 View commit details
    Browse the repository at this point in the history

  4. Remove a resolved question

    @joshtriplett
    joshtriplett committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ea1bd10 View commit details
    Browse the repository at this point in the history

  5. Rework the RFC to use values of the field type: negative numbers and … 

    …floats

Drop support for enums for now, since using values of the enum type
would require name resolution. Add them to future possibilities.

Allow open-start ranges (exclusive and inclusive), since they were only
disallowed for forward-compatibility with signed values. Add an explicit
note that open-start ranges will include negative values.
    @joshtriplett
    joshtriplett committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    5358cb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Rephrase descriptions of ranges

    @joshtriplett
    joshtriplett committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    08244e0 View commit details
    Browse the repository at this point in the history