This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Allow the tooltip tests to run in isolation #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
suggested changes
Nov 30, 2018
Prior to this change, the tooltip tests were unknowingly dependent on the other test harness setting the `RUSTC` environment variable, which caused the hover test project build to hang. Also renamed the hover test project's `main.rs` to `lib.rs` for correctness. The test project built before, but did not build successfully due to a missing main function.
aloucks
force-pushed
the
tooltip-test-isolation
branch
from
923bf29 to
9c6f344
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the tooltip tests were unknowingly dependent on the other test harness setting the
RUSTCenvironment variable.This caused the hover test project build to hang (e.g. when running
cargo test tooltip). However, runningcargo test hoverwould succeed due to the other test harness setting the environment variable.Also renamed the hover test project's
main.rstolib.rsfor correctness. The test project built before, but did not build successfully due to a missing main function.Related: #1151