Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Don't return symbols with empty names #1193

Merged
merged 1 commit into from
Dec 17, 2018

Commits on Dec 17, 2018

  1. Don't return symbols with empty names

    Although LSP does not define what constitutes a valid symbol name, VS
    Code's client implementation explicitly prohibits symbols with empty
    names. Currently, RLS returns such symbols in many cases (for example,
    the root module of a binary crate). These symbols not only fail to
    parse in VS Code, but in fact cause it to throw an exception that
    prevents the symbol list from being populated *at all*.
    
    To fix this, filter out symbols with empty names before returning them
    to the client.
    tchebb committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    1210105 View commit details
    Browse the repository at this point in the history