Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Various cosmetic improvements #1314

Closed
wants to merge 2 commits into from
Closed

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Feb 16, 2019

Related to the larger effort of rust-lang/rust#58036.

rls/src/actions/hover.rs Outdated Show resolved Hide resolved
rls/src/actions/hover.rs Outdated Show resolved Hide resolved
rls/src/actions/hover.rs Outdated Show resolved Hide resolved
rls/src/actions/hover.rs Outdated Show resolved Hide resolved
@alexreg
Copy link
Contributor Author

alexreg commented Feb 16, 2019

@h-michael Thanks for pointing out the unresolved conflict. That is fixed and pushed now.

@Xanewok
Copy link
Member

Xanewok commented Feb 19, 2019

Thank you for the PR! Could you please rebase on top of the current master? This should fix the compilation errors (due to #1315, assuming Clippy didn't break again 😢 🤞 )

@alexreg
Copy link
Contributor Author

alexreg commented Feb 21, 2019

@Xanewok Sure. And sorry for the delay (busy couple of days). Hopefully all is fine with CI now...

@bors
Copy link
Contributor

bors commented Feb 24, 2019

☔ The latest upstream changes (presumably #1320) made this pull request unmergeable. Please resolve the merge conflicts.

@alexreg
Copy link
Contributor Author

alexreg commented Feb 24, 2019

@Xanewok Not sure why the previous commit failed CI. It looked like an error internal to clippy, perhaps?

@Xanewok
Copy link
Member

Xanewok commented Feb 24, 2019

Yeah, this was due to stale clippy version.

@alexreg Because of the fact that text offsets are affected by removing copyright notices, this needs an update to the text offsets. I did that already in ff90258, could you cherry-pick that and double-check that tests pass on your side?

bors added a commit that referenced this pull request Feb 24, 2019
Various cosmetic improvements

Closes #1314 (same PR + follow up test fixes).
@Xanewok
Copy link
Member

Xanewok commented Feb 24, 2019

Since that commit was based on this anyway, to reduce turnaround time I pushed a PR with your commits and the fixes on top of that.

Thanks once again!

@alexreg
Copy link
Contributor Author

alexreg commented Feb 24, 2019

@Xanewok No problem. And cheers for sorting out the text offsets!

@bors bors closed this in #1326 Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants