Skip to content

Commit

Permalink
Auto merge of #17353 - roife:fix-issue-12728, r=Veykril
Browse files Browse the repository at this point in the history
fix: incorrect formatting of hover actions

fix #12728.

### Changes

- Use ` | ` as the separator for actions. (I'm not sure why we use `___` previously)
- Reorder actions to match codelens
  • Loading branch information
bors committed Jun 6, 2024
2 parents af488c9 + 4a4b13c commit 5f3de78
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion crates/ide/src/hover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ pub(crate) fn hover_for_definition(
HoverResult {
markup: render::process_markup(sema.db, def, &markup, config),
actions: [
show_implementations_action(sema.db, def),
show_fn_references_action(sema.db, def),
show_implementations_action(sema.db, def),
runnable_action(sema, def, file_id),
goto_type_action_for_def(sema.db, def, &notable_traits),
]
Expand Down
2 changes: 1 addition & 1 deletion editors/code/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function renderHoverActions(actions: ra.CommandLinkGroup[]): vscode.MarkdownStri
(group.title ? group.title + " " : "") +
group.commands.map(renderCommand).join(" | "),
)
.join("___");
.join(" | ");

const result = new vscode.MarkdownString(text);
result.isTrusted = true;
Expand Down

0 comments on commit 5f3de78

Please sign in to comment.