Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format_args! is broken #15082

Closed
Veykril opened this issue Jun 19, 2023 · 0 comments · Fixed by #15559
Closed

format_args! is broken #15082

Veykril opened this issue Jun 19, 2023 · 0 comments · Fixed by #15559
Assignees
@Veykril
Labels
A-macro macro expansion A-nameres name, path and module resolution Broken Window Bugs / technical debt to be addressed immediately

Comments

@Veykril
Copy link
Member

Veykril commented Jun 19, 2023 

          The `format_args` is broken even on nightly. The problem is that `Argument` is defined inside `core::fmt::rt` which is a private module so even if we use `core::fmt::rt::Argument` (we are currently using `core::fmt::Argument`) it wouldn't work. So it seems lang paths are the only way to access that. We need to either make the lang paths a special ast node, or make the entire `format_args!()` a special ast node similar to what rustc does.

Originally posted by @HKalbasi in #14980 (comment)

We'll need to think of a way to address this in a future proofed way as this issue may re-appear whether it be for format_args or another new macro
@HKalbasi HKalbasi mentioned this issue Jun 19, 2023
Merged
bors added a commit that referenced this issue Jun 19, 2023
@bors
Auto merge of #15093 - HKalbasi:format-args, r=HKalbasi
ff02add 
Use `ArgumentV1` instead of `Argument`

Now that the choice is between supporting stable and supporting nothing, let's support stable.

cc #15082
bors added a commit that referenced this issue Jun 19, 2023
@bors
Auto merge of #15093 - HKalbasi:format-args, r=HKalbasi
40ed61e 
Use `ArgumentV1` instead of `Argument`

Now that the choice is between supporting stable and supporting nothing, let's support stable.

cc #15082
@lowr lowr added A-macro macro expansion A-nameres name, path and module resolution labels Jun 23, 2023
@y21 y21 mentioned this issue Jul 19, 2023
Closed
@lnicola lnicola mentioned this issue Aug 5, 2023
Closed
@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Sep 2, 2023
@Veykril Veykril mentioned this issue Sep 5, 2023
Merged
bors added a commit that referenced this issue Sep 5, 2023
@bors
Auto merge of #15557 - Veykril:builtin-syntax, r=Veykril
caeea45 
Parse builtin# syntax and add typechecking for builtin#offset_of expression

Also removes box syntax, fixes #14504

cc rust-lang/compiler-team#580 #15082
@Veykril Veykril self-assigned this Sep 5, 2023
@Veykril Veykril mentioned this issue Sep 5, 2023
Merged
@bors bors closed this as completed in f29867b Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
A-macro macro expansion A-nameres name, path and module resolution Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement builtin#format_args, using rustc's format_args parser Veykril/rust-analyzer
2 participants
@Veykril @lowr