You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we are trying to upmap the run function node from the expansion, we will fail due to all the new tokens that have been added that have varying spans and more importantly a differing syntax context from the input name (differing syntax context is an immediate bail currently). Ideally we'd still map the signature out of this, the question is how.
The text was updated successfully, but these errors were encountered:
The attribute could accommodate for us here but that would be the wrong way to go about this. The attribute is written with good diagnostic output in mind (that's where spans are mainly relevant). We should be able to improve this on our side, it's just that the logic for that be fleshed out a bit as currently its just very simplistic. That is figure out which tokens we can ignore while upmapping, which ones are relevant etc
Noticed in #16229
Taking async-trait as an example, given:
and the expansion of the attribute as:
When we are trying to upmap the
run
function node from the expansion, we will fail due to all the new tokens that have been added that have varying spans and more importantly a differing syntax context from the input name (differing syntax context is an immediate bail currently). Ideally we'd still map the signature out of this, the question is how.The text was updated successfully, but these errors were encountered: