Failed to download: fetch$1 is not a function

[kafji]

After upgrading to latest nightly (v0.3.409-nightly) my Vscode failed to download the language server binary and shows Failed to download: fetch$1 is not a function error popup.

I've tried the "Update Github Auth Token" and use my personal account token but the error persist.

RA client log:

DEBUG [12/8/2020, 9:41:49 AM]: Issuing request for released artifacts metadata to https://api.github.com/repos/rust-analyzer/rust-analyzer/releases/tags/nightly
ERROR [12/8/2020, 9:45:42 AM]: [TypeError: fetch$1 is not a function
	at Object.fetchRelease (/home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:17893:28)
	at /home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:18130:26
	at downloadWithRetryDialog (/home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:18277:26)
	at bootstrapExtension (/home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:18129:27)
	at bootstrap (/home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:18105:11)
	at async tryActivate (/home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:18028:24)
	at async activate (/home/asd/.vscode/extensions/matklad.rust-analyzer-0.3.409-nightly/out/src/main.js:18002:5)
	at async Promise.all (index 0)]

Copied from https://users.rust-lang.org/t/ra-failed-to-download-fetch-1-is-not-a-function/52464.

[hammypants]

Also getting this on nightly-- it's basically dead in the water atm.

[kafji]

This issue is introduced in 31f5044.

Maybe something related to rollup. https://github.com/rust-analyzer/rust-analyzer/blob/dfd0626dbfea6816d38e6f72ce84f567877603e7/editors/code/src/net.ts#L1-L3?

[kafji]

diff --git a/editors/code/src/net.ts b/editors/code/src/net.ts
index 9ba17b7b5..22cb38552 100644
--- a/editors/code/src/net.ts
+++ b/editors/code/src/net.ts
@@ -1,6 +1,7 @@
 // Replace with `import fetch from "node-fetch"` once this is fixed in rollup:
 // https://github.com/rollup/plugins/issues/491
-const fetch = require("node-fetch") as typeof import("node-fetch")["default"];
+// const fetch = require("node-fetch") as typeof import("node-fetch")["default"];
+import fetch from "node-fetch";
 
 import * as vscode from "vscode";
 import * as stream from "stream";

Does fix the issue.

[kafji]

Patched.

[mexus]

So for today we've got a broken nightly, right? Is it possible to somehow update it before tomorrow?

Re-installing the extension saves the day :)

[kafji]

So for today we've got a broken nightly, right?

I believe so.

Is it possible to somehow update it before tomorrow?

Yes. You can download the server binary and copy it to the expected path.

[mexus]

Thanks @kafji ! So far re-installing the extension helped, but who knows what happens tomorrow.. it's still 2020 after all..

[chinoto]

I was just about to open an issue, but then I decided to check the closed issues, thanks for the fix, @kafji, and how to get the fix to stick, @mexus. (Do I have my comma grammar right?)