-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitattributes for fix Windows Line-ending problem in generated_grammar_is_fresh
#1115
Conversation
876e21c
to
7ca0a10
Compare
bors r+ Thanks! |
1115: Add .gitattributes for fix Windows Line-ending problem in `generated_grammar_is_fresh` r=matklad a=edwin0cheng Although #937 is marked as `Closed` . But it should work without setting `core.autocrlf` to `false` by this PR. Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Note that we explicitly don't test rust-analyzer on windows in hope that it is cross-platform by construction: #819 This might be a bad idea long term, but it might not! |
Build succeeded |
Personally i prefer travis build time to testing in Windows too. Just in case someone (like me) try to run |
The practical problem here is that downloading docs via rustup on windows takes more time than the whole Linux CI :-( And I think that bors time should be optimized as best as we can. One though I've toyed with, but never implemented, is to switch to some kind of dockerized setup, where we use pre-installed stable rustup on CI. That might allow us to run both windows and linux builds (if there's some alternative to docker on windows) fast. |
Docker itself! https://docs.docker.com/docker-for-windows/ |
Also, if we move for cross-platform CI for this repo, we should probably investigate azure pipelines: having all platforms covered by the same provider is neat. I've set up azure for ra_vfs. It wasn't too pretty, but neither is travis or appveyor. |
Although #937 is marked as
Closed
. But it should work without settingcore.autocrlf
tofalse
by this PR.