Add const generics #11688
Merged
Add const generics #11688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodiebold
reviewed
Mar 12, 2022
flodiebold
reviewed
Mar 12, 2022
|
✌️ HKalbasi can now approve this pull request. To approve and merge a pull request, simply reply with |
bors
added a commit
to rust-lang/chalk
that referenced
this pull request
Mar 12, 2022
Add missing fold_free_var_const This causes panic in rust-lang/rust-analyzer#11688 when `Sized` trait is in tests.
HKalbasi
force-pushed
the
const_generic
branch
3 times, most recently
from
1f450d9 to
765593b
Compare
|
bors r+ |
|
Build succeeded:
|
|
This seems to have broken |
bors bot
added a commit
that referenced
this pull request
Mar 15, 2022
11718: Fix const generic panic r=lnicola a=HKalbasi fix #11688 (comment) Co-authored-by: hkalbasi <hamidrezakalbasi@protonmail.com>
lnicola
reviewed
Mar 21, 2022
| impl std::fmt::Display for ConstScalarOrPath { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| ConstScalarOrPath::Scalar(s) => write!(f, "{}", s), |
There was a problem hiding this comment.
Nit:
Suggested change
| ConstScalarOrPath::Scalar(s) => write!(f, "{}", s), | |
| ConstScalarOrPath::Scalar(s) => s.fmt(f), | |
| ConstScalarOrPath::Path(n) => n.fmt(f), |
There was a problem hiding this comment.
Ah, sorry, this was already merged 🤦. I'll file a PR to clean these up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7434 is not in this PR, so there is no evaluation of constants and no default const argument. But the rest (type inference and method resolution with chalk) should work.
Chalk is pedantic about kind of generic arguments, and will panic in case of mixing type and const arguments. I tried to add test that, but I'm not sure if it covers all cases.