Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove old inlay hints settings #12006

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Apr 16, 2022

Closes #11998

@lnicola
Copy link
Member Author

lnicola commented Apr 16, 2022

I still think we should remove this command and point users to https://marketplace.visualstudio.com/items?itemName=hoovercj.vscode-settings-cycler instead, and this would be a good time to do it, but since we're not decided on that, we can make it toggle editor.inlayHints.enabled instead.

See also #6316, which that would fix.

@lnicola
Copy link
Member Author

lnicola commented Apr 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2022

📌 Commit f77adb3 has been approved by lnicola

@bors
Copy link
Contributor

bors commented Apr 16, 2022

⌛ Testing commit f77adb3 with merge 66c232d...

@bors
Copy link
Contributor

bors commented Apr 16, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 66c232d to master...

@bors bors merged commit 66c232d into rust-lang:master Apr 16, 2022
@lnicola lnicola deleted the toggle-inlay-hints branch April 16, 2022 05:38
bors added a commit that referenced this pull request Apr 20, 2022
fix: Remove `rust-analyzer.inlayHints.enable` and set language scope

Closes #12036
CC #12027 (comment)

The key was left there by mistake in #12006.

Setting the configuration scope only works if you already have it created, which is fine, but unfortunately not quite discoverable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode can't disable inlay hints
2 participants