-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: rename crates to kebab-case #12118
Conversation
Can you rebase? It seems there's a conflict on one file. |
Yes, I can. My current branch doesn't include the latest 4 changes. |
Great. We can't merge this because one of the newer changes touches a file in |
changelog internal (first contribution) rename crates to |
Looks like you rebased master onto your branch, not your branch onto master |
Yes, as I rarely use rebase, I've made the mistake and instantly regretted it. I secretly hoped it will go away (this trick never works btw). It came back to haunt me through your message @jonas-schievink :) |
@randomicon00 I think there's still a failing test that checks that a generated file is up to date. Do you need help with this? |
@lnicola I will have a look at it tonight or tomorrow morning and let you know. The test that fails is |
Looks good. If it's not too much of a hassle, can you do a final squash to get rid of the swapfile? @bors delegate+ |
✌️ @randomicon00 can now approve this pull request |
☔ The latest upstream changes (presumably #12099) made this pull request unmergeable. Please resolve the merge conflicts. |
As much as the task is trivial, as much as branch conflits seem to keep rolling! |
I would squash, then rebase and fix the conflicts. Then merge it without waiting for a review (leave a comment with @ bors r=lnicola). |
all tests are passing. @bors r=lnicola |
📌 Commit aade319 has been approved by |
☀️ Test successful - checks-actions |
Good thing we only had ~20 open PRs and not more 😅 |
Good morning! I squashed the last 6 commits. |
This broke the publish action as you can see by https://github.com/rust-lang/rust-analyzer/runs/6524727008?check_suite_focus=true#step:5:223. cc @jonas-schievink I am not sure why this change was made. |
This change was made for consistency, we had some crates using kebab-case and some using snake_case before. |
So, how do we fix the old crates being named with |
Ref: #12102
I updated all the folders names as well as the crates names in each
Cargo.toml
to use kebab-case.This is my first ra PR. In case I missed something, I am ready/available to fix it until it is ready to merge.
Thank you.