Implement IntoFuture type inference #12982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
reviewed
Aug 9, 2022
Veykril
reviewed
Aug 10, 2022
flodiebold
reviewed
Aug 16, 2022
|
Thanks! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my projects is using IntoFuture to make our async code a little less verbose. However, rust-analyzer can't infer the output type of an await expression if the value uses
IntoFutureto convert into another type. So we're getting{unknown}types everywhere since switching.foo.awaititself desugars into amatch into_future(foo) {}, with everyFutureimpl getting a defaultIntoFutureimplementation. I'm not sure if we want to disable the oldfuture_traitpaths, since this only recently stabilize.