Move VSCode diagnostics workaround into client code #13016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Aug 13, 2022
Move VSCode diagnostics workaroudn into client code
Veykril
force-pushed
the
vscode-diag-workaround
branch
from
1d66361
to
14bb1c3
Compare
lnicola
reviewed
Aug 13, 2022
Veykril
force-pushed
the
vscode-diag-workaround
branch
from
14bb1c3
to
ec8256d
Compare
|
@bors r+ |
Veykril
changed the title
|
Do we unflatten the messages in |
|
☀️ Test successful - checks-actions |
|
uuh, good question let me just fix that up as well |
bors
added a commit
that referenced
this pull request
Aug 13, 2022
Pad empty diagnostic messages in relatedInformation as well Follw up to #13016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.