Filter imports on find-all-references

[enomado]

Attempt to #13184

[lnicola]

I'm not sure we want this by default. For example, "Find usages" on a trait should probably include the use statements, since our trait solving is still quite imprecise (though I'm not sure how well that works at the moment).

[enomado]

I'm not sure we want this by default. For example, "Find usages" on a trait should probably include the use statements, since our trait solving is still quite imprecise (though I'm not sure how well that works at the moment).

Its okay. Its my first attempt. It may be configurable. I'll use my own fork, at the worst.

[Veykril]

This should definitely have a config option that is disabled by default (ideally it wouldn't be a config but a client side filter for the results, but I don't think thats possible yet)

See https://github.com/rust-lang/rust-analyzer/blob/master/crates/rust-analyzer/src/config.rs, as for the config key, something like references_include_use should be good I suppose

[enomado]

So. I have added config and tested on a few cases.

[enomado]

Could somebody assist me? my cargo test panics locally on some ABI stuff. but CI wants me to commit generated files

    NOTE: run `cargo test` locally and commit the updated files

thread 'config::tests::generate_config_documentation' panicked at 'Some files were not up-to-date', crates/rust-analyzer/src/config.rs:2035:9

[lnicola]

Try cargo test -p rust-analyzer, then commit the modified files.

[enomado]

ready

[enomado]

ready №2

[Veykril]

Thanks!
@bors r+

[bors]

📌 Commit f7f4792 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit f7f4792 with merge e38dfe5...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e38dfe5 to master...

[matklad]

@Veykril note that the original intended design here is a bit different: filtering should be done in 2proto module (that is, we always return all usages, and filter out imports near the edge)

This comes from perfect client thinking, which client would just classify usages in its UI (eg, it’ll show “9001 usages in imports” which is collapsed by default).

don’t remember exactly, but there should be some kind of Class filed on a usage which should classify it into ctor/dtor/read/write/use/comment.

[Veykril]

Yes, I realized that the filtering should (and could) happen in the proto layer instead after merging as well. Meant to change that but didn't find the time today. There is a classification for this of some sort (which is very bare bones still I believe)