Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Substitute some VSCode variables in the VSCode client #13423

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 16, 2022

cc #13405

@Veykril Veykril marked this pull request as ready for review October 17, 2022 09:54
@Veykril
Copy link
Member Author

Veykril commented Oct 17, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2022

📌 Commit d5f467a has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 17, 2022

⌛ Testing commit d5f467a with merge 40cbeb5...

@bors
Copy link
Contributor

bors commented Oct 17, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 40cbeb5 to master...

@bors bors merged commit 40cbeb5 into rust-lang:master Oct 17, 2022
@Veykril Veykril deleted the vscode-vars branch October 17, 2022 10:22
@lnicola lnicola changed the title Substitute some VSCode variables in the VSCode client feat: Substitute some VSCode variables in the VSCode client Oct 17, 2022
@davidbarsky
Copy link
Contributor

Oh, thanks for doing this! I was gonna write it anyways, but it's great to be able to start resolving this issue sooner than I expected :)

@Veykril
Copy link
Member Author

Veykril commented Oct 17, 2022

I was rewriting things anyways for #13426 so I went and took a look at this while I was at it :)

@ashb
Copy link

ashb commented Oct 21, 2022

👍 Thanks, for this -- I just switched to the nightly/pre-release VsCode extension and it fixed my problem (of specifying VIRUTAL_ENV relative to workspaceFolder for a pyo3 project)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants