Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Update proc-macro-srv tests #13625

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Nov 16, 2022

Should have been included in #13548, but I didn't notice as those tests aren't run in our CI.

cc rust-lang/rust#104454

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2022
@lowr
Copy link
Contributor Author

lowr commented Nov 16, 2022

cc @lnicola

I didn't run the tests locally because I don't really know how :/ Are there other proc-macro tests that only run during rust-lang/rust's CI and may fail due to #13548?

@lnicola
Copy link
Member

lnicola commented Nov 16, 2022

Thanks, I wanted to take a look but didn't get to it yet. The tests were disabled in #13286 because we were hitting the UnsupportedABI path. I'm not sure at this moment what it would take to run them against the sysroot proc_macro.

@lnicola
Copy link
Member

lnicola commented Nov 16, 2022

I mean, the ghetto option would be to rustup default 1.63 and RUN_SLOW_TESTS=1 cargo test 😆.

@lowr
Copy link
Contributor Author

lowr commented Nov 16, 2022

Having taken a look at that PR, I think this patch is all we need to make their CI happy again.

@lnicola
Copy link
Member

lnicola commented Nov 16, 2022

Ah, never mind, it's too annoying to do.

@lnicola
Copy link
Member

lnicola commented Nov 16, 2022

Yeah, I agree.

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Nov 16, 2022

📌 Commit 7577c44 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 16, 2022

⌛ Testing commit 7577c44 with merge 9cf5c22...

@bors
Copy link
Contributor

bors commented Nov 16, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 9cf5c22 to master...

@bors bors merged commit 9cf5c22 into rust-lang:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants