Rename checkOnSave settings to check
#13799
Conversation
rustbot
added
the
S-waiting-on-review
|
Sounds like a good idea to be consistent about this. I don't think the more obscure name is a problem. |
|
I don't know, flycheck is a term from Emacs which can make this kind of confusing if people search for the term, and it also doesn't really tell you anything. (Also, AIUI it's called "flycheck" because it checks on the fly while typing, so the name makes just as little sense as "check on save" anymore.) I would be ok with just |
|
Oh okay, let's not use flycheck publicly if it clashes with terminology from emacs, that does sound like a bad choice. |
Veykril
changed the title
checkOnSave settings to check
| f.splitn(2, '_').next().unwrap() | ||
| } | ||
| assert!(key(f1) <= key(f2), "wrong field order: {f1:?} {f2:?}"); | ||
| } |
There was a problem hiding this comment.
We already assert this via a separate test
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This setting was renamed in rust-lang/rust-analyzer#13799
|
Just a note that I think this broke any configuration users had already set based on |
|
@kylebarron the server still understands the old preference, even if it shows up as unused in Code. |
|
For me when I updated to the latest rust-analyzer version, clippy-on-save stopped working entirely 🤷♂️. It wasn't until I switched |
|
Idle musing: I wonder if we should add a "Run Clippy on crate/workspace" to the existing "Rust-Analyzer: Run", as an alternative to setting Clippy as the check command. |
|
@kylebarron FWIW, I can't reproduce that:
|
|
🤷♂️. I probably did something wrong! sorry for the noise! |
`checkOnSave` settings were renamed to `check` in rust-lang/rust-analyzer#13799 This allows VS Code IntelliSense to show a description on hover in the settings.json file instead of "Unknown Configuration Setting". The old setting still works, so this doesn't change other behaviour. Differential Revision: https://phabricator.services.mozilla.com/D176792
`checkOnSave` settings were renamed to `check` in rust-lang/rust-analyzer#13799 This allows VS Code IntelliSense to show a description on hover in the settings.json file instead of "Unknown Configuration Setting". The old setting still works, so this doesn't change other behaviour. Differential Revision: https://phabricator.services.mozilla.com/D176792 UltraBlame original commit: 99a6ee7ee5e45a34fee26c5c8c9ae4ba8215a23c
`checkOnSave` settings were renamed to `check` in rust-lang/rust-analyzer#13799 This allows VS Code IntelliSense to show a description on hover in the settings.json file instead of "Unknown Configuration Setting". The old setting still works, so this doesn't change other behaviour. Differential Revision: https://phabricator.services.mozilla.com/D176792 UltraBlame original commit: 99a6ee7ee5e45a34fee26c5c8c9ae4ba8215a23c
`checkOnSave` settings were renamed to `check` in rust-lang/rust-analyzer#13799 This allows VS Code IntelliSense to show a description on hover in the settings.json file instead of "Unknown Configuration Setting". The old setting still works, so this doesn't change other behaviour. Differential Revision: https://phabricator.services.mozilla.com/D176792 UltraBlame original commit: 99a6ee7ee5e45a34fee26c5c8c9ae4ba8215a23c
`checkOnSave` settings were renamed to `check` in rust-lang/rust-analyzer#13799 This allows VS Code IntelliSense to show a description on hover in the settings.json file instead of "Unknown Configuration Setting". The old setting still works, so this doesn't change other behaviour. Differential Revision: https://phabricator.services.mozilla.com/D176792
See rust-lang/rust-analyzer#13799 for context of renaming this rust-anaylzer setting
Now that flychecks can be triggered without saving the setting name doesn't make that much sense anymore. This PR renames it to just
check, but keepscheckOnSaveas the enabling setting.