fix: Add tuple to render_const_scalar #14223
Conversation
rustbot
added
the
S-waiting-on-review
|
I think showing |
There was a problem hiding this comment.
Thanks so much for implementing it so quickly!
I think showing
<not-supported>,<layout-error>and similar is a pretty bad user experience, but currently display is widely assumed to be infallible. Thoughts?
It might look better if we write _ for any value we cannot render, but it could also hide potential bugs and be confusing for users (<not-supported> and the like are at least descriptive). Not too sure about this.
crates/hir-ty/src/display.rs
Outdated
| let Ok(layout) = layout_of_ty(f.db, &ty, krate) else { | ||
| return f.write_str("<layout-error>"); | ||
| }; |
There was a problem hiding this comment.
Is this else branch reachable at this point? I assume not, as layout_of_ty() for the tuple itself would have failed if that for any of the inner types would, but if it is, this seems to result in incomplete rendering like (42, <layout-error>.
There was a problem hiding this comment.
Nice catch! I changed it to continue instead of return. It is indeed unreachable but unreachable things might be reached sometimes.
|
I think |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
cc @lowr