Map our diagnostics to rustc and clippy's ones #14990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jun 9, 2023
|
Huh, I canceled an old pending review which caused it to be posted? 🤨 |
|
I ended up ignoring all lints in the proc macros since I think the infrastructure for handling them correctly is not there yet, and false negatives are generally better than false positives. r? @Veykril |
|
Let's merge this now to find its potential problems in nightly releases. |
|
☀️ Test successful - checks-actions |
|
oh sorry, I think I missed your ping back then 😅 |
|
That's fine :) I was just not super confident about the changes in |
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And control their severity by lint attributes
#[allow],#[deny]and ... .It doesn't work with proc macros and I would like to fix that before merge but I don't know how to do it.