Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: support #[rustc_coinductive] #15125

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Jun 24, 2023

rust-lang/rust#100386 changed the trait solver so that Sized is treated as coinductive trait, just like auto traits. This is now controlled by the perma-unstable #[rustc_coinductive] attribute (rust-lang/rust#108033), which this PR adds support for.

In practice, I don't think this matters much if at all. Currently we don't give chalk enough information so chalk cannot precisely (dis)prove Sized bounds.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2023
@lowr lowr marked this pull request as ready for review June 25, 2023 14:40
@Veykril
Copy link
Member

Veykril commented Jun 28, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 28, 2023

📌 Commit d026479 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 28, 2023

⌛ Testing commit d026479 with merge 0216044...

@bors
Copy link
Contributor

bors commented Jun 28, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 0216044 to master...

@bors bors merged commit 0216044 into rust-lang:master Jun 28, 2023
@Veykril
Copy link
Member

Veykril commented Jul 1, 2023

This seemed to have a big impact on diesels type mismatches for some reason 🤔
image

@lowr
Copy link
Contributor Author

lowr commented Jul 1, 2023

That's the least expected consequence 😕 I'll revert this PR if I cannot fix it by the next release.

@Veykril
Copy link
Member

Veykril commented Jul 1, 2023

Could there be some interplay with old editions? Iirc the diesel benchmark is 2015 edition

bors added a commit that referenced this pull request Jul 2, 2023
Revert "Support `#[rustc_coinductive]`"

Reverts #15125, addresses #15125 (comment)

I'll add the support again once I figure out the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants