fix: avoid problematic serde release #15481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serde 1.0.172 and up rely on opaque non-reproducible binary blobs to function, explicitly not providing a library-level opt-out. This is problematic for two reasons: - directly, unauditable binary blobs are a security issue. - indirectly, it becomes much harder to predict future behaviors of the crate. As such, I am willing to go on a limb here and forbid building rust-analyzer with those versions of serde. Normally, my philosophy is to defer the choice to the end user, but it's also a design constraint of rust-analyzer that we don't run random binaries downloaded from the internet without explicit user's concent. Concretely, this upper-bounds serde for both rust-analyzer workspace, as well as the lsp-server lib. See serde-rs/serde#2538 for wider context.
rustbot
added
the
S-waiting-on-review
ahlinc
reviewed
Aug 19, 2023
| @@ -9,7 +9,8 @@ edition = "2021" | |||
| [dependencies] | |||
| log = "0.4.17" | |||
| serde_json = "1.0.96" | |||
| serde = { version = "1.0.156", features = ["derive"] } | |||
| # See https://github.com/serde-rs/serde/issues/2538#issuecomment-1684517372 for why we pin serde | |||
| serde = { version = "1.0.156, < 1.0.171", features = ["derive"] } | |||
There was a problem hiding this comment.
I think there is a mistake and it should be < 1.0.172 like on https://github.com/rust-lang/rust-analyzer/pull/15481/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R101
There was a problem hiding this comment.
Yeah, looks like 1.0.171 is the latest version without it.
|
reopened as #15482 --- github's having trouble with updateing the PR after a --force-with-lease? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde 1.0.172 and up rely on opaque non-reproducible binary blobs to
function, explicitly not providing a library-level opt-out.
This is problematic for two reasons:
crate.
As such, I am willing to go on a limb here and forbid building
rust-analyzer with those versions of serde. Normally, my philosophy is
to defer the choice to the end user, but it's also a design constraint
of rust-analyzer that we don't run random binaries downloaded from the
internet without explicit user's concent.
Concretely, this upper-bounds serde for both rust-analyzer workspace, as
well as the lsp-server lib.
See serde-rs/serde#2538 for wider context.