-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Switch to expected.assert_eq
for ide
tests
#16252
Conversation
This is meant for test fixtures (the code that is passed to tests as strings), those dont see std library stuff. Testing infra is free to use whatever.
On second though thats probably not worth it given the number of files changed is usually 1 anyways |
@bors r+ |
expected.assert_eq
for ide
testsexpected.assert_eq
for ide
tests
☀️ Test successful - checks-actions |
This PR switches from
assert_debug_eq
toassert_eq
and only compares parts of the result and not the whole. The aim is to only compare parts which are relevant to the test and also make it more readable.Part of #14268.
Questions
Vec
? If not, what is the alternative?I assume I cannot because of:
rust-analyzer/docs/dev/architecture.md
Line 413 in c3a00b5
CreateFile
events? They do not have a FileId, which would be problematic, but they do not occur in the existing tests, so I marked them asunreachable!()
so far.