feat: Implement module_path macro
#17936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
commented
Aug 21, 2024
Comment on lines
+145
to
+147
| // This isn't really eager, we have no inputs, but we abuse the fact how eager macros are | ||
| // handled in r-a to be able to thread the module path through. | ||
| (module_path, ModulePath) => module_path_expand |
There was a problem hiding this comment.
The magic that makes things work despite our crate split (I hate this hack)
Veykril
changed the title
module_path macromodule_path macro
Veykril
changed the title
module_path macromodule_path macro
Veykril
commented
Aug 23, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
6 tasks
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 29, 2024
…=Veykril Revert "feat: Implement `module_path` macro" Reverts rust-lang/rust-analyzer#17936 Fixes rust-lang/rust-analyzer#17968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this is a pain to implement because of our hir-def hir-expand split :)