Revert "Resolve completion items" #18501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting this commit fixes automatic importing in many editors. This reverts commit 950bb83.
rustbot
added
the
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting this commit fixes automatic importing in many editors.
Certainly there's probably a better way to fix this than a straight revert. But this does get things working again. Feel free, of course, to close this if a more targeted fix is available.
This fixes #18363.
This reverts commit 950bb83.
cc @Veykril @SomeoneToIgnore