By default, log only to stderr, and not to disk.

[eminence]

This fixes a common problem when running under VS Code, the user doesn't have permissions to create a log directory in the CWD.

The old behavior can be re-enabled by setting RA_INTERNAL_MODE=1

Fixes #282

[DJMcNab]

Nit: can you not do the match statement as

if std::env::var("RA_INTERNAL_MODE“) == Ok(“1“){
   ... 
} 

? I might be wrong, and can't check atm

[eminence]

You can't do that because Ok("1") is a Result<&str>, but std::env::var returns a Result<String>.

You could of course do Ok("1".to_owned()), but I thought I'd skip the allocation with a match guard instead.

[DJMcNab]

Ah, well we don't really care about allocations in ra_lsp_server.

Anyway, here's the tracking issue for the api that would allow this easily. rust-lang/rust#50264 .

[matklad]

bors r+

Thanks!

[bors]

Build succeeded

• continuous-integration/travis-ci/push

[DJMcNab]

Actually, I think we can also do

let var = std::env::var("RA_INTERNAL_MODE“);
if var.map(Deref::deref) ==Ok("1"){
   ... 
}