Extend analysis-stats a bit #3157
Conversation
This adds some tools helpful when debugging nondeterminism in analysis-stats: - a `--randomize` option that analyses everything in random order - a `-vv` option that prints even more detail Also add a debug log if Chalk fuel is exhausted (which would be a source of nondeterminism, but didn't happen in my tests). I found one source of nondeterminism (rust-lang/chalk#331), but there are still other cases remaining.
| pico-args = "0.3.0" | ||
| env_logger = { version = "0.7.1", default-features = false } | ||
| rand = { version = "0.7.0", features = ["small_rng"] } |
There was a problem hiding this comment.
I think this is fine, but I'd love to remove deps on rand altogether one day. I don't like that we have two of them.
For our purposes, this should be enough.
(immediate action here is blocked on removing proptest in favor of quickcheck. and cc BurntSushi/quickcheck#241)
There was a problem hiding this comment.
Using a PRNG would make it deterministic, which is exactly the opposite of what the --randomize option is supposed to do.
There was a problem hiding this comment.
For our purposes, seeding with current time (good old srand(time(NULL))) should be enough, we don't need OS-level crypto random numbers.
There was a problem hiding this comment.
I did check whether we still depended on rand, and only added it since we already depend on it 😄 I didn't really want to implement shuffle myself for this.
|
forgot one thing... bors r+ |
3157: Extend analysis-stats a bit r=matklad a=flodiebold This adds some tools helpful when debugging nondeterminism in analysis-stats: - a `--randomize` option that analyses everything in random order - a `-vv` option that prints even more detail Also add a debug log if Chalk fuel is exhausted (which would be a source of nondeterminism, but didn't happen in my tests). I found one source of nondeterminism (rust-lang/chalk#331), but there are still other cases remaining. Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Build succeeded
|
This adds some tools helpful when debugging nondeterminism in analysis-stats:
--randomizeoption that analyses everything in random order-vvoption that prints even more detailAlso add a debug log if Chalk fuel is exhausted (which would be a source of
nondeterminism, but didn't happen in my tests).
I found one source of nondeterminism (rust-lang/chalk#331), but there are still
other cases remaining.