Reduce memory usage by using global Arc-based interning
#8284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Apr 1, 2021
|
Added interning of more types. Memory impact looks roughly like this: |
jonas-schievink
changed the title
Arc-based interning
|
Nice, we should try that for types as well! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 1, 2021
8284: Reduce memory usage by using global `Arc`-based interning r=jonas-schievink a=jonas-schievink This saves around 50 mb when running `analysis-stats` on r-a itself. Not a lot, but this infra can be easily reused to intern more stuff. Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
|
Timed out. |
bors retry |
bors bot
added a commit
that referenced
this pull request
Apr 1, 2021
8284: Reduce memory usage by using global `Arc`-based interning r=jonas-schievink a=jonas-schievink This saves around 50 mb when running `analysis-stats` on r-a itself. Not a lot, but this infra can be easily reused to intern more stuff. Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
|
Build failed: |
matklad
reviewed
Apr 2, 2021
matklad
reviewed
Apr 2, 2021
|
I wonder if we might want do something like this, but without interning, for basically everything? I still have a picture in my head where all things of the same type are co-allocated in the same table, instead of being owned by parents. |
|
bors r+ |
|
changelog fix |
|
This put quite a dent in the memory usage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves around 50 mb when running
analysis-statson r-a itself. Not a lot, but this infra can be easily reused to intern more stuff.