Layout test should pass clippy borrow_as_ptr lint #2205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated layout tests should pass the borrow_as_ptr lint.
|
Just a nit I stumbled upon... Let me know if I missed something 😄 |
|
Thanks. This appears it would conflict with (and probably solve most or all the same problem as) #2203. If someone has time to evaluate additional differences between this PR and that one, it might be helpful. I personally am not an Regardless, I think you did indeed find a real issue: the underlying #1651. |
|
Actually I think this PR leaves the UB in place, so it is only tangentially related to #1651. It will be useful to obey the Clippy lint as well. Could you check whether #2203 obeys the lint already, @dlrobertson? |
|
Ah! Woops! Should have looked through the PRs before opening one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated layout tests should pass the borrow_as_ptr lint.
Fixes: #2204